Avoid unneeded slice+splice in _pageData #16555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.slice().splice(index, pageSize) will create an unneeded full copy of the underlying data, and then also mutate it to splice a page. Neither of these operations are needed, and can be particularly slow for larger datasets. .slice(index, index + indexPageSize) is almost constant time. In case of a datasource with 1,000,000 rows (big, yes, but not absurdly so), pagination is currently visibly sluggish on my machine. Benchmarks seem to blame this: https://measurethat.net/Benchmarks/ShowResult/62222
googlebot
added
the
cla: yes
jelbourn
approved these changes
Jul 18, 2019
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the cleanup!
jelbourn
added
G
This comment has been minimized.
This comment has been minimized.
jelbourn
added
target: patch
andrewseguin
pushed a commit
that referenced
this pull request
Jul 29, 2019
.slice().splice(index, pageSize) will create an unneeded full copy of the underlying data, and then also mutate it to splice a page. Neither of these operations are needed, and can be particularly slow for larger datasets. .slice(index, index + indexPageSize) is almost constant time. In case of a datasource with 1,000,000 rows (big, yes, but not absurdly so), pagination is currently visibly sluggish on my machine. Benchmarks seem to blame this: https://measurethat.net/Benchmarks/ShowResult/62222
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.slice().splice(index, pageSize) will create an unneeded full copy of the underlying data, and then also mutate it to splice a page. Neither of these operations are needed, and can be particularly slow for larger datasets.
.slice(index, index + indexPageSize) is almost constant time.
In case of a datasource with 1,000,000 rows (big, yes, but not absurdly so), pagination is currently visibly sluggish on my machine. Benchmarks seem to blame this: https://measurethat.net/Benchmarks/ShowResult/62222