refactor(checkbox): remove unused host binding for required validator #16548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `mat-checkbox` required validator defines a host binding that adds the "required" attribute to the `mat-checkbox` host element. This is not necessary as the `required` attribute should be only added to the underlying input element (which is handled as part of the checkbox template). This unnecessary host binding seems to have been added by accident since the `CheckboxRequiredValidator` from `@angular/forms` has the same host binding. Through the difference is that the `CheckboxRequiredValidator` from `@angular/forms` is guaranteed to have native input elements as host element.
devversion
added
the
target: patch
googlebot
added
the
cla: yes
crisbeto
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Jul 29, 2019
…#16548) Currently the `mat-checkbox` required validator defines a host binding that adds the "required" attribute to the `mat-checkbox` host element. This is not necessary as the `required` attribute should be only added to the underlying input element (which is handled as part of the checkbox template). This unnecessary host binding seems to have been added by accident since the `CheckboxRequiredValidator` from `@angular/forms` has the same host binding. Through the difference is that the `CheckboxRequiredValidator` from `@angular/forms` is guaranteed to have native input elements as host element.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
mat-checkboxrequired validator defines a host bindingthat adds the "required" attribute to the
mat-checkboxhost element.This is not necessary as the
requiredattribute should be only addedto the underlying input element (which is handled as part of the checkbox
template).
This unnecessary host binding seems to have been added by
accident since the
CheckboxRequiredValidatorfrom@angular/formshas the same host binding. Through the difference is that the
CheckboxRequiredValidatorfrom@angular/formsis guaranteedto have native input elements as host element.