Skip to content

build: setup RBE caching and remote build event service on CI #16370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2019
Merged

build: setup RBE caching and remote build event service on CI #16370

merged 1 commit into from
Jun 24, 2019

Conversation

@josephperrott
Copy link
Member

@josephperrott josephperrott commented Jun 24, 2019

No description provided.

@josephperrott josephperrott added the in progress This issue is currently in progress label Jun 24, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 24, 2019
@josephperrott josephperrott force-pushed the rbe-setup branch 5 times, most recently from 7970ce2 to 8269033 Compare June 24, 2019 19:19
@josephperrott josephperrott changed the title chore(ci): setup Remote Build Execution caching and Remote Build Event service build: setup Remote Build Execution caching and Remote Build Event service on CI Jun 24, 2019
@josephperrott josephperrott changed the title build: setup Remote Build Execution caching and Remote Build Event service on CI build: setup RBE caching and remote build event service on CI Jun 24, 2019
@josephperrott josephperrott added pr: merge safe target: patch This PR is targeted for the next patch release and removed in progress This issue is currently in progress labels Jun 24, 2019
@josephperrott
Copy link
Member Author

josephperrott commented Jun 24, 2019

Cuts the bazel_targets job from ~16 minutes to ~9 minutes:
Before caching - https://circleci.com/workflow-run/cf9ba3df-d136-4e6c-aae1-cecd5421b450
After caching - https://circleci.com/workflow-run/47d02826-ec76-41ad-a85b-1352147a3c20

devversion
devversion approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice 🎉

@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Jun 24, 2019
jelbourn
jelbourn approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit d511fbe into angular:master Jun 24, 2019
@josephperrott josephperrott deleted the rbe-setup branch June 24, 2019 21:41
andrewseguin pushed a commit that referenced this pull request Jul 2, 2019
@josephperrott @andrewseguin
build: setup RBE caching and remote build event service on CI (#16370)
d4ab49a
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 11, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn jelbourn approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@josephperrott @jelbourn @devversion @googlebot