Skip to content

fix(tree): unable to set zero as the padding of a tree node #16345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2019
Merged

fix(tree): unable to set zero as the padding of a tree node #16345

merged 1 commit into from
Jul 19, 2019

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 20, 2019

Fixes setting zero as the padding of a tree node being ignored by the CkdTreeNodePadding directive.

Fixes #16338.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jun 20, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 20, 2019
@crisbeto crisbeto force-pushed the 16338/tree-zero-padding branch from 48c3ec6 to 92e37c4 Compare June 20, 2019 21:02
jelbourn
jelbourn approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto force-pushed the 16338/tree-zero-padding branch from 92e37c4 to ceacaed Compare June 20, 2019 22:31
@jelbourn
Copy link
Member

jelbourn commented Jun 20, 2019

Looks like some legit test failures

@crisbeto
fix(tree): unable to set zero as the padding of a tree node
3dd317b 
Fixes setting zero as the padding of a tree node being ignored by the `CkdTreeNodePadding` directive.

Fixes angular#16338.
@crisbeto crisbeto force-pushed the 16338/tree-zero-padding branch from ceacaed to 3dd317b Compare June 21, 2019 04:57
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 21, 2019
@jelbourn jelbourn merged commit 3bd160b into angular:master Jul 19, 2019
andrewseguin pushed a commit that referenced this pull request Jul 29, 2019
@crisbeto @andrewseguin
fix(tree): unable to set zero as the padding of a tree node (#16345)
bf66d81 
Fixes setting zero as the padding of a tree node being ignored by the `CkdTreeNodePadding` directive.

Fixes #16338.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 11, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cdkTreeNodePadding level is ignored

3 participants

@crisbeto @jelbourn @googlebot