feat(icon): allow viewBox to be configured when registering icons #16320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P4
googlebot
added
the
cla: yes
jelbourn
reviewed
Jun 21, 2019
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
This was something I had been holding off on because I wanted it to be part of cdk-svg, but it's probably going to be a while before we can really do that, so we might as well do it here
This has been a long-standing feature request that has recently popped up again. Allows consumers to specify a `viewBox` for icons and icon sets when they're being registered. Fixes angular#2981. Fixes angular#16293.
crisbeto
force-pushed
the
2981/icon-registry-viewbox
branch
from
550bbc7 to
f378393
Compare
Member
Author
|
Reworked based on the feedback @jelbourn. |
|
Also would be nice to use the viewBox attribute of the symbol If already set. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a long-standing feature request that has recently popped up again. Allows consumers to specify a
viewBoxfor icons and icon sets when they're being registered.Fixes #2981.
Fixes #16293.