fix(ng-update): do not report form-field breaking change from v6 #16161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The misc rules currently run for every migration, but the one for the `shouldLabelFloat` was apparently using a wrong check that has been added back in the days when we pulled out the standalone migration tool into the material2 repository. While being at it, we are fixing that invalid check and limit the misc migration to the V6 upgrade target version. Fixes angular#16143
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
andrewseguin
added
the
P4
jelbourn
added
pr: lgtm
action: merge
devversion
added
P3
josephperrott
pushed a commit
that referenced
this pull request
Jun 10, 2019
) The misc rules currently run for every migration, but the one for the `shouldLabelFloat` was apparently using a wrong check that has been added back in the days when we pulled out the standalone migration tool into the material2 repository. While being at it, we are fixing that invalid check and limit the misc migration to the V6 upgrade target version. Fixes #16143
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
…ular#16161) The misc rules currently run for every migration, but the one for the `shouldLabelFloat` was apparently using a wrong check that has been added back in the days when we pulled out the standalone migration tool into the material2 repository. While being at it, we are fixing that invalid check and limit the misc migration to the V6 upgrade target version. Fixes angular#16143
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The misc rules currently run for every migration, but the one for the
shouldLabelFloatwas apparently using a wrong check that hasbeen added back in the days when we pulled out the standalone
migration tool into the material2 repository.
While being at it, we are fixing that invalid check and limit
the misc migration to the V6 upgrade target version.
Fixes #16143