Skip to content

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented May 24, 2019

I noticed that the MDC components were missing from MATERIAL_EXPERIMENTAL_PACKAGES. This PR fixes it and does some related cleanup

@mmalerba mmalerba added pr: merge safe target: patch This PR is targeted for the next patch release labels May 24, 2019
@mmalerba mmalerba requested review from devversion and jelbourn May 24, 2019 20:23
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 24, 2019
@devversion
Copy link
Member

devversion commented May 24, 2019

@mmalerba I see the point of doing this but I'm slightly afraid that this adds additional bloat to our build definitions and I'd personally advocate for just using tags.

e.g.

  • bazel test src/... runs everything
  • bazel test src/... --build_tag_filters=-e2e (runs everything except e2e)
  • bazel test src/... --build_tag_filters=e2e (runs only e2e tests)

We could make shortcuts for these in the package.json then as well. Similarly to how it is done for angular/angular.

I don't think its worth having an additional tag for unit tests though

@mmalerba
Copy link
Contributor Author

Ah cool, I didn't realize that was a thing. I like that better too. I fixed a couple random issues with the BUILD files while I was doing this, so I'll re-purpose this PR for fixing those and then just use the tags as you suggested for separating the tests

@mmalerba mmalerba changed the title test: add bazel targets to run all unit tests for each package build: fill in missing MATERIAL_EXPERIMENTAL_PACKAGES May 24, 2019
@mmalerba
Copy link
Contributor Author

@devversion PTAL

Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 24, 2019
@mmalerba mmalerba merged commit 755fd56 into angular:master May 24, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants