build: source maps for some dependencies not exposed during unit tests #16104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
devversion
approved these changes
May 23, 2019
devversion
added
pr: lgtm
action: merge
Fixes the source maps for all the `@material` dependencies, as well as `hammer`, `core.js` and `systemjs` not being served during unit tests.
crisbeto
force-pushed
the
test-dep-source-maps
branch
from
e0c9433 to
5fef4dc
Compare
jelbourn
approved these changes
May 24, 2019
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
I always turn off my JS sourcemaps in devtools, though. I find that it's easier to debug that way.
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
angular#16104) Fixes the source maps for all the `@material` dependencies, as well as `hammer`, `core.js` and `systemjs` not being served during unit tests.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the source maps for all the
@materialdependencies, as well ashammer,core.jsandsystemjsnot being served during unit tests.