-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(portal): add new portal that projects DOM nodes #16101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I've reworked it based on the feedback @jelbourn. |
|
LGTM |
|
The latest set of feedback has been addressed @jelbourn. |
jelbourn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just needs rebase
463ed62 to
d3ad339
Compare
|
Rebased. |
d3ad339 to
5015494
Compare
|
@crisbeto both Google Analytics and Google Cloud extend |
5015494 to
c607df3
Compare
c607df3 to
4bff85a
Compare
4bff85a to
ed683d2
Compare
Adds a new type of portal called `DomPortal` which transfers the contents of a portal into the portal outlet and then restores them on destroy. This was implemented initially for angular#14430.
ed683d2 to
94652fd
Compare
|
Updated @mmalerba. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds a new type of portal called
DomPortalwhich transfers the contents of a portal into the portal outlet and then restores them on destroy.This was implemented initially for #14430.