build: add lint rule to catch SimpleChanges direct property access #15659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a lint rule to help catch cases like angular#15206 until we can get something going through tsetse. Note this is only scoped to `ngOnChanges` and accesses of the `SimpleChanges` objects since that's where we've been having issues.
crisbeto
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
devversion
approved these changes
Mar 30, 2019
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM. This is fine since the tsetse rule is currently still disabled by default within rules_typescript and we are not able to enable this (which is a limitation of tsetse at the moment).
devversion
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a lint rule to help catch cases like #15206 until we can get something going through tsetse. Note this is only scoped to
ngOnChangesand accesses of theSimpleChangesobjects since that's where we've been having issues.