build: dgeni bazel target misses runtime fine-grained dep #15649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the fact that various targets only depend on their TypeScript source Bazel target, the logic that is reponsible for determining the Bazel managed dependency path is not working because the `nodejs_binary` rule is not able to determine the `NodeModuleInfo` Bazel provider from the TypeScript compilation provider output. See: https://github.com/bazelbuild/rules_nodejs/blob/fe1d1c03630f999c57a63dc3fe1f6ad52ff61c6a/internal/node/node.bzl#L60 Therefore we need to make sure that we don't transitively depend on fine-grained dependencies (such as `@npm//highlight.js`) which *seem* to be transitively brought in by the TypeScript target. This is not correct and prone to unexpected failures (as we experienced on `master)
googlebot
added
the
cla: yes
devversion
added
pr: merge safe
target: patch
mmalerba
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the fact that various targets only depend on their TypeScript
source Bazel target, the logic that is reponsible for determining the
Bazel managed dependency path is not working because the
nodejs_binaryrule is not able to determine theNodeModuleInfoBazel provider from the TypeScript compilation provider output.
See: https://github.com/bazelbuild/rules_nodejs/blob/fe1d1c03630f999c57a63dc3fe1f6ad52ff61c6a/internal/node/node.bzl#L60
Therefore we need to make sure that we don't transitively depend on
fine-grained dependencies (such as
@npm//highlight.js) whichseem to be transitively brought in by the TypeScript target. This is not
correct and prone to unexpected failures (as we experienced on
master)