Skip to content

Conversation

@devversion
Copy link
Member

With Bazel it's uncommon to print anything except failures. Currently
the Dgeni logic that runs as part of our Bazel build is the only action
that prints something for a successful build. In order to make our Bazel
output clean, we lower the log level. For debugging, it's still easy to
modify the log-level.

With Bazel it's uncommon to print anything except failures. Currently
the Dgeni logic that runs as part of our Bazel build is the only action
that prints something for a successful build. In order to make our Bazel
output clean, we lower the log level. For debugging, it's still easy to
modify the log-level.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Mar 17, 2019
@devversion devversion requested a review from jelbourn as a code owner March 17, 2019 17:48
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 17, 2019
@devversion devversion changed the title build: do not run dgeni with "info" log level. build: do not run dgeni with "info" log level Mar 17, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 21, 2019
@ngbot
Copy link

ngbot bot commented Mar 21, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@andrewseguin andrewseguin merged commit 59e26f6 into angular:master Mar 22, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants