Skip to content

fix(slide-toggle): able to receive focus while disabled on click #15501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2019
Merged

fix(slide-toggle): able to receive focus while disabled on click #15501

merged 1 commit into from
Mar 20, 2019

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 15, 2019

Along the same lines as #15499. Fixes the slide toggle being focusable via click when it's disabled.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Mar 15, 2019
@crisbeto crisbeto requested a review from devversion as a code owner March 15, 2019 21:51
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 15, 2019
devversion
devversion approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto
fix(slide-toggle): able to receive focus while disabled on click
65ca0fe 
Along the same lines as angular#15499. Fixes the slide toggle being focusable via click when it's disabled.
@crisbeto crisbeto force-pushed the slide-toggle-disabled-focus-click branch from 027df6a to 65ca0fe Compare March 16, 2019 15:51
@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Mar 16, 2019
@andrewseguin andrewseguin merged commit e8827e2 into angular:master Mar 20, 2019
andrewseguin pushed a commit that referenced this pull request Mar 25, 2019
@crisbeto @andrewseguin
fix(slide-toggle): able to receive focus while disabled on click (#15501
479618e 
)

Along the same lines as #15499. Fixes the slide toggle being focusable via click when it's disabled.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

Assignees

@devversion devversion

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @devversion @googlebot @andrewseguin