Skip to content

test(input): make the type validation test to pass in Ivy #15460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2019
Merged

test(input): make the type validation test to pass in Ivy #15460

merged 1 commit into from
Mar 13, 2019

Conversation

@marclaval
Copy link
Contributor

@marclaval marclaval commented Mar 13, 2019

In Ivy, static inputs are evaluated in creation mode, just after directives for that node are created. So this test is throwing immediately when the component is created, not during the first change detection.

@marclaval marclaval requested a review from mmalerba as a code owner March 13, 2019 16:17
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 13, 2019
@marclaval marclaval mentioned this pull request Mar 13, 2019
Merged
crisbeto
crisbeto approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 13, 2019
@mmalerba mmalerba merged commit aa95d6b into angular:master Mar 13, 2019
mmalerba pushed a commit that referenced this pull request Mar 18, 2019
@marclaval @mmalerba
test(input): make the type validation test to pass in Ivy (#15460)
79d1f9f
Suresh918 pushed a commit to Suresh918/material2 that referenced this pull request Apr 15, 2019
@marclaval
test(input): make the type validation test to pass in Ivy (angular#15460
e62d5d6 
)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marclaval @crisbeto @googlebot @mmalerba