Skip to content

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 6, 2019

Disables the auto-formatting in vscode until we can format the entire codebase.

Disables the auto-formatting in vscode until we can format the entire codebase.
@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Mar 6, 2019
@crisbeto crisbeto requested a review from mmalerba as a code owner March 6, 2019 21:52
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 6, 2019
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Mar 6, 2019
@ngbot
Copy link

ngbot bot commented Mar 6, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing
    pending status "ci/circleci: api_golden_checks" is pending
    pending status "ci/circleci: bazel_build_test" is pending
    pending status "ci/circleci: build_release_packages" is pending
    pending status "ci/circleci: e2e_tests" is pending
    pending status "ci/circleci: lint" is pending
    pending status "ci/circleci: prerender_build" is pending
    pending status "ci/circleci: tests_browserstack" is pending
    pending status "ci/circleci: tests_local_browsers" is pending
    pending status "ci/circleci: tests_saucelabs" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@josephperrott josephperrott added target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release labels Mar 7, 2019
@josephperrott josephperrott merged commit fbae483 into angular:master Mar 7, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants