refactor(button): use [attr.disabled] host binding in MatButton #15308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With ivy, MatAnchor will inherit the host bindings of MatButton. The `[disabled]` binding would then be an error since HTMLAnchorElement does not have a `disabled` property. To work around this, we can simply use the `disabled` attribute instead, which will always be reflected back into the property when it exists. Also add a missing `fixture.detectChanges()` to a test.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
kara
added
the
P1
Suresh918
pushed a commit
to Suresh918/material2
that referenced
this pull request
Apr 15, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ivy, MatAnchor will inherit the host bindings of MatButton. The
[disabled]binding would then be an error since HTMLAnchorElement doesnot have a
disabledproperty. To work around this, we can simply usethe
disabledattribute instead, which will always be reflected backinto the property when it exists.
Also add a missing
fixture.detectChanges()to a test.