Skip to content

fix(icon): clearing user content when svgIcon is bound to falsy value #15290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2019
Merged

fix(icon): clearing user content when svgIcon is bound to falsy value #15290

merged 1 commit into from
Mar 20, 2019

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 24, 2019

Fixes the mat-icon component clearing the user's content and potentially a valid ligature icon, if there's also an svgIcon attribute.

@crisbeto
fix(icon): clearing user content when svgIcon is bound to falsy value
55998de 
Fixes the `mat-icon` component clearing the user's content and potentially a valid ligature icon, if there's also an `svgIcon` attribute.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 24, 2019
@crisbeto crisbeto requested a review from jelbourn as a code owner February 24, 2019 18:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 24, 2019
jelbourn
jelbourn approved these changes Feb 25, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 25, 2019
@andrewseguin andrewseguin merged commit d646266 into angular:master Mar 20, 2019
andrewseguin pushed a commit that referenced this pull request Mar 25, 2019
@crisbeto @andrewseguin
fix(icon): clearing user content when svgIcon is bound to falsy value (…
f2f1232 
…#15290)

Fixes the `mat-icon` component clearing the user's content and potentially a valid ligature icon, if there's also an `svgIcon` attribute.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @jelbourn @googlebot @andrewseguin