fix(schematics): do not generate invalid stylesheet files #15235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
commented
Feb 19, 2019
| * List of supported styles which are CSS supersets. All supported CLI style extensions can be | ||
| * found here: angular/angular-cli/master/packages/schematics/angular/ng-new/schema.json#L118-L122 | ||
| */ | ||
| const supportedCssSupersets = ['scss', 'less']; |
Member
Author
There was a problem hiding this comment.
@jelbourn I decided to do in a safelist-fashion as "technically" the CLI could add new unsupported style extensions which will then break. This way we guarantee that we never generate invalid stylesheets.
devversion
added
pr: merge safe
target: patch
jelbourn
reviewed
Feb 19, 2019
| * List of supported styles which are CSS supersets. All supported CLI style extensions can be | ||
| * found here: angular/angular-cli/master/packages/schematics/angular/ng-new/schema.json#L118-L122 | ||
| */ | ||
| const supportedCssSupersets = ['scss', 'less']; |
Currently whenever someone specified Stylus or Sass as the default style extension for their Angular CLI project, the CDK/ Material schematics incorrectly generate files with that given extension. This is problematic because the schematic style templates are written in CSS and therefore are not compatible with Stylus or Sass (which are not supersets of CSS unlike less, scss) Fixes angular#15164
devversion
force-pushed
the
fix/schematics-do-not-generate-invalid-stylesheet-files
branch
from
806479b to
c904590
Compare
jelbourn
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
Feb 20, 2019
Currently whenever someone specified Stylus or Sass as the default style extension for their Angular CLI project, the CDK/ Material schematics incorrectly generate files with that given extension. This is problematic because the schematic style templates are written in CSS and therefore are not compatible with Stylus or Sass (which are not supersets of CSS unlike less, scss) Fixes #15164
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently whenever someone specified Stylus or Sass as the
default style extension for their Angular CLI project, the CDK/
Material schematics incorrectly generate files with that given
extension. This is problematic because the schematic style
templates are written in CSS and therefore are not compatible
with Stylus or Sass (which are not supersets of CSS unlike less, scss)
Fixes #15164