fix(docs): Icons in the toolbar example are missing alternative text … #15128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
reviewed
Feb 10, 2019
| <mat-icon class="example-icon">favorite</mat-icon> | ||
| <span class="cdk-visually-hidden">Example heart icon</span> | ||
| <mat-icon class="example-icon">delete</mat-icon> | ||
| <span class="cdk-visually-hidden">Example delete icon</span> |
Member
There was a problem hiding this comment.
These labels should be set as an aria-label on the mat-icon, rather than a span next to it.
Contributor
Author
There was a problem hiding this comment.
Changed as per your suggestion. Can you please check now
jelbourn
approved these changes
Feb 14, 2019
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
I think that this example needs some other improvements since the the toolbar is basically just a colored div, but that can be dealt with at some future date.
jelbourn
added
pr: lgtm
docs
jelbourn
pushed a commit
that referenced
this pull request
Feb 20, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15041