Skip to content

Revert "perf(focus-monitor): avoid triggering change detection if there are no subscribers to stream" #15076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 4, 2019
Merged

Revert "perf(focus-monitor): avoid triggering change detection if there are no subscribers to stream" #15076

merged 2 commits into from
Feb 4, 2019

Conversation

@mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Feb 4, 2019

Reverts #14964

@crisbeto it looks like there is an app that was depending on these extra change detections being run. It's proving difficult to debug so I'm going to revert for now. We can investigate and try to merge again in the future

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 4, 2019
@mmalerba mmalerba merged commit bc6b700 into master Feb 4, 2019
@crisbeto crisbeto mentioned this pull request Feb 4, 2019
Merged
mmalerba added a commit that referenced this pull request Feb 4, 2019
@mmalerba
Revert "perf(focus-monitor): avoid triggering change detection if the…
e6500fb 
…re are no subscribers to stream" (#15076)

* Revert "fix(radio): unable to click to select button if text is marked (#14967)"

This reverts commit 5846038.

* Revert "perf(focus-monitor): avoid triggering change detection if there are no subscribers to stream (#14964)"

This reverts commit 085bbb7.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
@josephperrott josephperrott deleted the revert-14964-focus-monitor-change-detection branch June 29, 2022 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion Awaiting requested review from devversion

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmalerba @googlebot