Skip to content

fix(table): Clarify unknown table column error #14947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2019
Merged

fix(table): Clarify unknown table column error #14947

merged 1 commit into from
Jan 30, 2019

Conversation

@CaptainCow95
Copy link
Contributor

@CaptainCow95 CaptainCow95 commented Jan 24, 2019

Throwing error when column not found in _addStickyColumnStyles to avoid weird error of
"Cannot read property 'sticky' of undefined".

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 24, 2019
crisbeto
crisbeto reviewed Jan 26, 2019
View reviewed changes
@CaptainCow95
fix(table): Clarify unknown table column error
615ef55 
Throwing error when column not found in _addStickyColumnStyles to avoid weird error of
"Cannot read property 'sticky' of undefined".
crisbeto
crisbeto approved these changes Jan 27, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 27, 2019
@mmalerba mmalerba merged commit e136fc8 into angular:master Jan 30, 2019
mmalerba pushed a commit that referenced this pull request Feb 4, 2019
@CaptainCow95 @mmalerba
fix(table): Clarify unknown table column error (#14947)
2782273 
Throwing error when column not found in _addStickyColumnStyles to avoid weird error of
"Cannot read property 'sticky' of undefined".
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CaptainCow95 @crisbeto @googlebot @mmalerba