Skip to content

fix(select): optionSelectionChanges not emitting when the list of options changes #14814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2019
Merged

fix(select): optionSelectionChanges not emitting when the list of options changes #14814

merged 1 commit into from
May 13, 2019

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 13, 2019

Along the same lines as #14813. Fixes MatSelect.optionSelectionChanges not emitting if the list options changes.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 13, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 13, 2019
@crisbeto crisbeto force-pushed the select-option-selections branch from 50fc5c6 to 75bdbe5 Compare January 25, 2019 21:45
jelbourn
jelbourn approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker P4 A relatively minor issue that is not relevant to core functions labels Apr 2, 2019
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@crisbeto
fix(select): optionSelectionChanges not emitting when the list of opt…
91b9076 
…ions changes

Along the same lines as angular#14813. Fixes `MatSelect.optionSelectionChanges` not emitting if the list options changes.
@crisbeto crisbeto force-pushed the select-option-selections branch from 75bdbe5 to 91b9076 Compare May 4, 2019 06:53
@jelbourn jelbourn merged commit f6cd86e into angular:master May 13, 2019
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
@crisbeto @RudolfFrederiksen
fix(select): optionSelectionChanges not emitting when the list of opt…
e7e0de3 
…ions changes (angular#14814)

Along the same lines as angular#14813. Fixes `MatSelect.optionSelectionChanges` not emitting if the list options changes.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @jelbourn @googlebot @mmalerba