Skip to content

Conversation

josephperrott
Copy link
Member

No description provided.

@josephperrott josephperrott added pr: merge safe target: patch This PR is targeted for the next patch release labels Jan 9, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 9, 2019
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 9, 2019
@ngbot
Copy link

ngbot bot commented Jan 9, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_saucelabs" is failing
    pending status "ci/circleci: bazel_build_test" is pending
    pending status "ci/circleci: tests_local_browsers" is pending
    pending status "ci/circleci: tests_browserstack" is pending
    pending status "ci/circleci: build_devapp_aot" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@devversion
Copy link
Member

Caretaker note: Saucelabs failing because of https://status.saucelabs.com/incidents/y46340ngq3qk, which now results in a lot of PRs acquiring tunnels.

@andrewseguin andrewseguin merged commit 9e74f9d into angular:master Jan 9, 2019
@josephperrott josephperrott deleted the branch-manager branch January 9, 2019 22:15
andrewseguin added a commit that referenced this pull request Jan 9, 2019
andrewseguin pushed a commit that referenced this pull request Jan 10, 2019
josephperrott added a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants