Skip to content

docs(drag-drop) correct 'lockAxis' to 'cdkDropListLockAxis' #14578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 2, 2019
Merged

docs(drag-drop) correct 'lockAxis' to 'cdkDropListLockAxis' #14578

merged 1 commit into from
Jan 2, 2019

Conversation

@IlCallo
Copy link
Contributor

@IlCallo IlCallo commented Dec 19, 2018 •
edited
Loading

Alike #13802
Closes #14572

@IlCallo IlCallo requested a review from crisbeto as a code owner December 19, 2018 15:33
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 19, 2018
crisbeto
crisbeto approved these changes Dec 20, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The CI failure is because the PR was opened while we had a build issue in master.

@crisbeto crisbeto added pr: lgtm docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 20, 2018
@ngbot
Copy link

ngbot bot commented Dec 20, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: api_golden_checks" is failing
    pending status "branch-manager" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba merged commit 65d615b into angular:master Jan 2, 2019
@crisbeto crisbeto mentioned this pull request Jan 5, 2019
Closed
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@IlCallo @josephperrott
docs(drag-drop) correct 'lockAxis' to 'cdkDropListLockAxis' (angular#…
2a416d0 
…14578)

Alike angular#13802
Closes angular#14572
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(docs): lockAxis should be cdkDropListLockAxis on Drag&Drop overview

4 participants

@IlCallo @crisbeto @googlebot @mmalerba