Skip to content

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 6, 2018

Fixes the first option not appearing as highlighted if the consumer has set floatLabel="never" and autoActiveFirstOption. It looks like we were depending on the transitioned event from the label to kick off the change detection that shows the highlight.

Fixes #13734.

@crisbeto crisbeto added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release labels Dec 6, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 6, 2018
@crisbeto
Copy link
Member Author

crisbeto commented Dec 6, 2018

Caretaker note: this is a resubmit of #13774 which had to be reverted due to sync issues.

@crisbeto crisbeto closed this Dec 6, 2018
@crisbeto crisbeto force-pushed the 13734/autocomplete-auto-active-float-label branch from 91d90df to 63be232 Compare December 6, 2018 20:24
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Autocomplete]: autoActiveFirstOption not working when tabbing in with disabled floatLabel

3 participants