fix(stepper): ignoring custom falsy value for hasError #14337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `hasError` input allows people to override the error state of a step, however we currently ignore falsy values because of an incorrect ||. These changes also fix one of the test fixtures where an error was being swallowed silently. Fixes angular#14333.
googlebot
added
the
cla: yes
mmalerba
approved these changes
Dec 3, 2018
mmalerba
pushed a commit
that referenced
this pull request
Dec 10, 2018
The `hasError` input allows people to override the error state of a step, however we currently ignore falsy values because of an incorrect ||. These changes also fix one of the test fixtures where an error was being swallowed silently. Fixes #14333.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
The `hasError` input allows people to override the error state of a step, however we currently ignore falsy values because of an incorrect ||. These changes also fix one of the test fixtures where an error was being swallowed silently. Fixes angular#14333.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hasErrorinput allows people to override the error state of a step, however we currently ignore falsy values because of an incorrect ||.These changes also fix one of the test fixtures where an error was being swallowed silently.
Fixes #14333.