Skip to content

build: update to latest sass_rules version #14187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2018
Merged

build: update to latest sass_rules version #14187

merged 1 commit into from
Nov 20, 2018

Conversation

@devversion
Copy link
Member

@devversion devversion commented Nov 17, 2018

@devversion
build: update to latest sass_rules version
c502f64 
* Updates to the latest version of the Bazel sass rules because the release now includes: bazelbuild/rules_sass@1c7b293
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 17, 2018
@devversion devversion requested a review from jelbourn as a code owner November 17, 2018 16:10
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 17, 2018
josephperrott
josephperrott approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 20, 2018
@josephperrott josephperrott merged commit 16f53a7 into angular:master Nov 20, 2018
josephperrott pushed a commit that referenced this pull request Nov 20, 2018
@devversion @josephperrott
build: update to latest sass_rules version (#14187)
4e17003
josephperrott pushed a commit that referenced this pull request Nov 20, 2018
@devversion @josephperrott
build: update to latest sass_rules version (#14187)
6b9df8e
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrott josephperrott josephperrott approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@josephperrott josephperrott

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion @josephperrott @jelbourn @googlebot