Skip to content

build: dev-app with bazel #14162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 19, 2018
Merged

build: dev-app with bazel #14162

merged 3 commits into from
Nov 19, 2018

Conversation

@devversion
Copy link
Member

@devversion devversion commented Nov 15, 2018

Blocked on #14143

@devversion devversion added blocked This issue is blocked by some external factor, such as a prerequisite PR pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 15, 2018
@devversion devversion requested a review from jelbourn as a code owner November 15, 2018 17:42
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 15, 2018
@devversion devversion added the in progress This issue is currently in progress label Nov 15, 2018
@devversion devversion removed the in progress This issue is currently in progress label Nov 16, 2018
@devversion
Copy link
Member Author

devversion commented Nov 16, 2018

@jelbourn This should be ready for review. Just blocked on the 7.0.4 update PR.

jelbourn
jelbourn approved these changes Nov 16, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Nov 19, 2018
@josephperrott josephperrott merged commit c618dde into angular:master Nov 19, 2018
josephperrott pushed a commit that referenced this pull request Nov 19, 2018
@devversion @josephperrott
build: dev-app with bazel (#14162)
da81be5
josephperrott pushed a commit that referenced this pull request Nov 19, 2018
@devversion @josephperrott
build: dev-app with bazel (#14162)
8d9db6a
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion @jelbourn @googlebot @josephperrott