Skip to content

Conversation

@crisbeto
Copy link
Member

Adds an extra flag on the CdkDragDrop event that indicates whether the user's pointer was over the container when they dropped an item.

Fixes #14136.

@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Nov 14, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 14, 2018
@ngbot
Copy link

ngbot bot commented Nov 14, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto force-pushed the 14136/drag-drop-out-of-container branch from 4347f22 to ff41c63 Compare November 15, 2018 06:00
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Nov 15, 2018
@jelbourn
Copy link
Member

@crisbeto API gold needs to be updated.

…utside of container

Adds an extra flag on the `CdkDragDrop` event that indicates whether the user's pointer was over the container when they dropped an item.

Fixes angular#14136.
@crisbeto crisbeto force-pushed the 14136/drag-drop-out-of-container branch from ff41c63 to 0939700 Compare November 27, 2018 18:25
@crisbeto crisbeto requested a review from devversion as a code owner November 27, 2018 18:25
@crisbeto
Copy link
Member Author

@jelbourn goldens have been updated.

@jelbourn jelbourn merged commit 42de6a2 into angular:master Nov 28, 2018
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
…utside of container (angular#14140)

Adds an extra flag on the `CdkDragDrop` event that indicates whether the user's pointer was over the container when they dropped an item.

Fixes angular#14136.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(@angular/cdk/cdkDrag): cdkDragEnded out of a container

3 participants