Skip to content

Conversation

@devversion
Copy link
Member

  • Initial implementation of a rule that can transform markdown files to the equivalent HTML output. This is the foundation for packaging the guides into the //src/material-examples package (see: Package docs content into an npm package #13454)

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 12, 2018
@devversion devversion requested a review from jelbourn as a code owner November 12, 2018 18:43
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 12, 2018
* Initial implementation of a rule that can transform markdown files to the equivalent HTML output. This is the foundation for packaging the guides into the `//src/material-examples` package (see: angular#13454)
@devversion devversion force-pushed the build/transform-markdown-html-bazel branch from e6c4978 to effeb6b Compare November 12, 2018 19:42

# TODO(jelbourn): Update this command to run all tests if the Bazel issues have been fixed.
- run: bazel build src/...
- run: bazel test src/...
Copy link
Member Author

@devversion devversion Nov 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I don't want to build everything that is also outside of src. Running with //... seems to break our CI build, so I'll try to revisit that in a follow-up

@devversion devversion force-pushed the build/transform-markdown-html-bazel branch from 8b0ee05 to 14fd45f Compare November 13, 2018 17:49
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 14, 2018
@andrewseguin andrewseguin merged commit f31e9be into angular:master Nov 14, 2018
josephperrott pushed a commit that referenced this pull request Nov 19, 2018
* build: transform guide markdown files with bazel

* Initial implementation of a rule that can transform markdown files to the equivalent HTML output. This is the foundation for packaging the guides into the `//src/material-examples` package (see: #13454)

* Address feedback
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants