build: invalid browser name in karma config #14081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
devversion
reviewed
Nov 10, 2018
test/karma.conf.js
Outdated
| captureTimeout: 180000, | ||
|
|
||
| browsers: ['ChromeHeadlessLocal'], | ||
| browsers: ['ChromeHeadless'], |
Member
There was a problem hiding this comment.
Actually the real fix is to fix the browser name in the karma-browsers.json. I messed up the search and replace and didn't really realize that it also affected ChromeHeadlessLocal.
crisbeto
force-pushed
the
headless-chrome-local
branch
from
c75568e to
f665415
Compare
Fixes the name of the default browser in the Karma config being invalid and throwing an error when running the tests locally.
devversion
approved these changes
Nov 10, 2018
devversion
added
pr: lgtm
action: merge
vivian-hu-zz
pushed a commit
that referenced
this pull request
Nov 12, 2018
Fixes the name of the default browser in the Karma config being invalid and throwing an error when running the tests locally.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the name of the default browser in the Karma config being invalid and throwing an error when running the tests locally.