Skip to content

build: remove @angular/upgrade from dev dependencies #14068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2018
Merged

build: remove @angular/upgrade from dev dependencies #14068

merged 1 commit into from
Nov 9, 2018

Conversation

@devversion
Copy link
Member

@devversion devversion commented Nov 9, 2018

  • Removes @angular/upgrade from the dev dependencies.

@devversion
build: remove @angular/upgrade from dev dependencies
128e0b0 
* Removes `@angular/upgrade` from the dev dependencies.
@devversion devversion requested a review from jelbourn as a code owner November 9, 2018 18:54
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 9, 2018
jelbourn
jelbourn approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 9, 2018
@vivian-hu-zz vivian-hu-zz merged commit 41bb296 into angular:master Nov 9, 2018
@devversion devversion deleted the build/remove-ng-upgrade-dev-dep branch November 9, 2018 19:17
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
@devversion
build: remove @angular/upgrade from dev dependencies (#14068)
44322ee 
* Removes `@angular/upgrade` from the dev dependencies.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion @jelbourn @googlebot @vivian-hu-zz