Skip to content

fix(slide-toggle): showing focus ripple when clicking disabled control #14055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2018
Merged

fix(slide-toggle): showing focus ripple when clicking disabled control #14055

merged 1 commit into from
Nov 10, 2018

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 9, 2018 •
edited
Loading

Seems to be a regression from #13957. Since the focus monitor still tracks focus, even though the element is disabled, the focus ripple will show up when clicking on a disabled toggle.

Note: a similar issue is probably on #13959 and #13956 as well. I've applied the same fix there since the other PRs haven't been merged yet.

@crisbeto
fix(slide-toggle): showing focus ripple when clicking disabled control
970a4f6 
Seems to be a regression from angular#13957. Since the focus monitor still tracks focus, even though the element is disabled, the focus ripple will show up when clicking on a disabled toggle.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Nov 9, 2018
@crisbeto crisbeto requested a review from devversion as a code owner November 9, 2018 09:23
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 9, 2018
devversion
devversion approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 9, 2018
jelbourn
jelbourn approved these changes Nov 9, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vivian-hu-zz vivian-hu-zz merged commit 9b05c3c into angular:master Nov 10, 2018
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
@crisbeto
fix(slide-toggle): showing focus ripple when clicking disabled control (
a2c2caf 
#14055)

Seems to be a regression from #13957. Since the focus monitor still tracks focus, even though the element is disabled, the focus ripple will show up when clicking on a disabled toggle.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

Assignees

@jelbourn jelbourn

@devversion devversion

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@crisbeto @jelbourn @devversion @googlebot @vivian-hu-zz