Skip to content

Conversation

@devversion
Copy link
Member

Currently the Github robot is always pending on master because it looks like it couldn't load the artifacts from CircleCI.

Based on the source code of the Robot, the artifact paths need to be in a specific path in order to be taken into account.

* Currently the Github robot is always pending on `master` because it looks like it couldn't load the artifacts from CircleCI. Based on the source code of the Robot, the artifact paths need to be in a specific path in order to be taken into account.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 8, 2018
@devversion devversion requested a review from jelbourn as a code owner November 8, 2018 23:26
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 8, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 9, 2018
@vivian-hu-zz vivian-hu-zz merged commit ffe0c3e into angular:master Nov 10, 2018
vivian-hu-zz pushed a commit that referenced this pull request Nov 12, 2018
* Currently the Github robot is always pending on `master` because it looks like it couldn't load the artifacts from CircleCI. Based on the source code of the Robot, the artifact paths need to be in a specific path in order to be taken into account.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants