Skip to content

fix(chips): remove circular dependency between chip-list and chip-input #13994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2018
Merged

fix(chips): remove circular dependency between chip-list and chip-input #13994

merged 1 commit into from
Nov 5, 2018

Conversation

@jelbourn
Copy link
Member

@jelbourn jelbourn commented Nov 5, 2018

This change is necessary because some Google-internal infrastructure has
started encountering errors because of this particular circular dep.

@jelbourn
fix(chips): remove circular dependency between chip-list and chip-input
d0fbf6f 
This change is necessary because some Google-internal infrastructure has
started encountering errors because of this particular circular dep.
@jelbourn jelbourn added the target: patch This PR is targeted for the next patch release label Nov 5, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 5, 2018
vivian-hu-zz
vivian-hu-zz approved these changes Nov 5, 2018
View reviewed changes
Copy link
Contributor

@vivian-hu-zz vivian-hu-zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 5, 2018
@jelbourn jelbourn merged commit 6c741c4 into angular:master Nov 5, 2018
jelbourn added a commit that referenced this pull request Nov 6, 2018
@jelbourn
fix(chips): remove circular dependency between chip-list and chip-inp…
3da858d 
…ut (#13994)

This change is necessary because some Google-internal infrastructure has
started encountering errors because of this particular circular dep.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrott josephperrott Awaiting requested review from josephperrott

1 more reviewer

@vivian-hu-zz vivian-hu-zz vivian-hu-zz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jelbourn @vivian-hu-zz @googlebot