fix(button): stroked button crops applied badges #13912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we hide overflow for stroked buttons in order to properly handle the `border-radius` for the child ripple container and focus overlay, badges which are applied on the button will be clipped. In order to fix this bug, we just remove the `overflow: hidden` and go back to the initial implemenation where the border radius is inherited for the child elements. Just to keep angular#13738 resolved, we ensure that the child elements fully cover the actual button element for the _correct_ border radius. Fixes angular#13909
devversion
added
the
target: patch
googlebot
added
the
cla: yes
crisbeto
approved these changes
Oct 31, 2018
Member
crisbeto
left a comment
crisbeto
left a comment
There was a problem hiding this comment.
LGTM, but I'm not sure whether we shouldn't defer it to a minor. AFAIK the change in overflow could have some layout implications.
Member
Author
|
We added the |
Member
|
I think it should be fine for this to be in |
josephperrott
added
pr: lgtm
action: merge
Member
|
Looks like this actually fixes a regression caused in anchor buttons by #13745. The vertical spacing was messed up by |
atscott
pushed a commit
to atscott/components
that referenced
this pull request
Nov 5, 2018
Since we hide overflow for stroked buttons in order to properly handle the `border-radius` for the child ripple container and focus overlay, badges which are applied on the button will be clipped. In order to fix this bug, we just remove the `overflow: hidden` and go back to the initial implemenation where the border radius is inherited for the child elements. Just to keep angular#13738 resolved, we ensure that the child elements fully cover the actual button element for the _correct_ border radius. Fixes angular#13909
jelbourn
pushed a commit
that referenced
this pull request
Nov 6, 2018
Since we hide overflow for stroked buttons in order to properly handle the `border-radius` for the child ripple container and focus overlay, badges which are applied on the button will be clipped. In order to fix this bug, we just remove the `overflow: hidden` and go back to the initial implemenation where the border radius is inherited for the child elements. Just to keep #13738 resolved, we ensure that the child elements fully cover the actual button element for the _correct_ border radius. Fixes #13909
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we hide overflow for stroked buttons in order to properly handle the
border-radiusfor the child ripple container and focus overlay, badges which are applied on the button will be clipped.In order to fix this bug, we just remove the
overflow: hiddenand go back to the initial implemenation where the border radius is inherited for the child elements. Just to keep #13738 resolved, we ensure that the child elements fully cover the actual button element for the correct border radius.Fixes #13909