fix(cdk-platform): pass {} to @NgModule since passing nothing breaks in JIT mode
#13792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
added
P1
googlebot
added
the
cla: yes
devversion
added
pr: lgtm
action: merge
crisbeto
reviewed
Oct 24, 2018
Member
crisbeto
left a comment
crisbeto
left a comment
There was a problem hiding this comment.
Maybe add a comment that it’s necessary?
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 27, 2018
* Expands the decorator validation rule to allow us to run a regex against all the arguments of a decorator. This allows us to guard against cases like angular#13792. * Fixes a similar issue as angular#13792 in the `LayoutModule` which was caught after the new changes to the rule.
atscott
pushed a commit
to atscott/components
that referenced
this pull request
Nov 5, 2018
atscott
pushed a commit
to atscott/components
that referenced
this pull request
Nov 5, 2018
angular#13843) * Expands the decorator validation rule to allow us to run a regex against all the arguments of a decorator. This allows us to guard against cases like angular#13792. * Fixes a similar issue as angular#13792 in the `LayoutModule` which was caught after the new changes to the rule.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.