Skip to content

build: run browserstack on circleci #13749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2018
Merged

build: run browserstack on circleci #13749

merged 1 commit into from
Oct 24, 2018

Conversation

@devversion
Copy link
Member

@devversion devversion commented Oct 22, 2018

No description provided.

@devversion devversion requested a review from jelbourn as a code owner October 22, 2018 17:17
@devversion
Copy link
Member Author

devversion commented Oct 22, 2018

This is blocked for now because due to the GitHub issues, CircleCI is not able to run jobs for this PR.

@devversion devversion added blocked This issue is blocked by some external factor, such as a prerequisite PR cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release pr: merge safe labels Oct 22, 2018
josephperrott
josephperrott reviewed Oct 22, 2018
View reviewed changes
.circleci/config.yml Outdated
unit_tests:
jobs:
- tests_local_browsers
- browserstack_tests
Copy link
Member

@josephperrott josephperrott Oct 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do tests_browserstack. So the naming convention is consistent

Copy link
Member Author

@devversion devversion Oct 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Will update that

@googlebot

This comment has been minimized.

Sign in to view
@googlebot googlebot removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 22, 2018
@devversion devversion added the in progress This issue is currently in progress label Oct 22, 2018
@josephperrott josephperrott added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 22, 2018
@josephperrott
Copy link
Member

josephperrott commented Oct 22, 2018

CLA confirmed manually

@devversion devversion force-pushed the build/run-browserstack-circle branch 5 times, most recently from 4d15d1d to 7ac57b0 Compare October 23, 2018 07:04
@devversion devversion force-pushed the build/run-browserstack-circle branch from e35a2d7 to 0b9c94c Compare October 23, 2018 07:41
@devversion devversion removed blocked This issue is blocked by some external factor, such as a prerequisite PR in progress This issue is currently in progress labels Oct 23, 2018
jelbourn
jelbourn approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 24, 2018
@mmalerba mmalerba merged commit b30ec56 into angular:master Oct 24, 2018
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
@devversion @atscott
build: run browserstack on circleci (angular#13749)
2c07328
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 9, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrott josephperrott josephperrott left review comments

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

@josephperrott josephperrott

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@devversion @googlebot @josephperrott @jelbourn @mmalerba