chore(schematics): re-enable linting for ignored file #13542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: major
googlebot
added
the
cla: yes
devversion
changed the title
jelbourn
added
pr: lgtm
action: merge
devversion
force-pushed
the
chore/schematics-reenable-linting-build-component
branch
from
7824e3b to
5fb5e1a
Compare
* Re-enables linting for the `build-component` file which has been originally copied from `@schematics/angular`. For some reason, linting has been disabled explicitly for this file. This re-enables TSLint. * Also fixes a few shadowed variable failures (this logic comes from the `@schematics/angular:component` schematic and **should** be kept as similar as possible)
devversion
force-pushed
the
chore/schematics-reenable-linting-build-component
branch
from
5fb5e1a to
3651bd6
Compare
devversion
deleted the
chore/schematics-reenable-linting-build-component
branch
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
* Re-enables linting for the `build-component` file which has been originally copied from `@schematics/angular`. For some reason, linting has been disabled explicitly for this file. This re-enables TSLint. * Also fixes a few shadowed variable failures (this logic comes from the `@schematics/angular:component` schematic and **should** be kept as similar as possible)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enables linting for the
build-componentfile which has been originally copied from@schematics/angularbut partially modified by us. For some reason, linting has been disabled explicitly for this file. This re-enables TSLint.Also fixes a few shadowed variable failures (this logic comes from the
@schematics/angular:componentschematic and should be kept as similar as possible)