docs: show all available schematics in the schematics guide #13520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
changed the title
* Updates the outdated `schematics` guide to mention the new available component schematics.
devversion
force-pushed
the
chore/lupdate-schematics-md
branch
from
1994ff3 to
7a2521d
Compare
jelbourn
approved these changes
Oct 10, 2018
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
In reading this guide, I think I'll make a follow-up PR to do some general editing around the file as well.
guides/schematics.md
Outdated
| - [Dashboard](#dashboard-schematic) | ||
| - [Navigation](#navigation-schematic) | ||
| - [Table](#table-schematic) | ||
| - [Tree](#tree-schematic) |
Member
There was a problem hiding this comment.
Could you change this to a table where each row has the name and a brief description?
Member
Author
There was a problem hiding this comment.
Updated. I tried my best explaining the schematics in a short but accurate way. Also, yeah I agree that it would make sense to improve that whole document at some point.
jelbourn
added
pr: lgtm
action: merge
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
…13520) * docs: show all available schematics in the schematics guide * Updates the outdated `schematics` guide to mention the new available component schematics. * Address feedback
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
schematicsguide to mention the new available component schematics.