docs(virtual-scroll): add embedded examples #13327
Conversation
mmalerba
added
P2
mmalerba
requested review from
amcdnl,
andrewseguin and
crisbeto
as code owners
googlebot
added
the
cla: yes
mmalerba
added
pr: merge safe
target: patch
| } | ||
|
|
||
| .example-alternate { | ||
| background: rgba(0, 0, 0, .2); |
There was a problem hiding this comment.
I think we may end up with white text on a white background if somebody selected a dark theme in the docs site.
There was a problem hiding this comment.
I don't think our examples really support theme styles, but I'll use a 50% gray so it at least looks ok in either.
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| }) | ||
| export class CdkVirtualScrollContextExample { | ||
| items = Array.from({length: 100000}).map((_, i) => `Item #${i}`); |
There was a problem hiding this comment.
nit: Can be reduced to new Array(100000).fill(0).map((_, i) => Item #${i}) which is slightly shorter.
There was a problem hiding this comment.
Yeah I originally had that but switched it to this. This feels more readable to me, so I think its better for the purposes of an example.
mmalerba
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
No description provided.