Skip to content

docs(table): fix typo in MatRowDef description #13170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2018
Merged

docs(table): fix typo in MatRowDef description #13170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/table/row.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class MatFooterRowDef extends _CdkFooterRowDef {}

/**
* Data row definition for the mat-table.
* Captures the footer row's template and other footer properties such as the columns to display and
* Captures the data row's template and other properties such as the columns to display and
Copy link
Member

@crisbeto crisbeto Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this needs the "data" either, it can be just "Captures the row's template...".

Copy link
Contributor Author

@tplk tplk Sep 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crisbeto it can but I think it's more accurate to add "data" since first sentence states that it's "Data row definition for the mat-table."

Copy link
Contributor Author

@tplk tplk Sep 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it's clearer when described this way that it only relates to normal data rows and not header or footer rows.

* a when predicate that describes when this row should be used.
*/
@Directive({
Expand Down