Skip to content

refactor(schematics): add test cases for method-calls and import checks #13157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2018
Merged

refactor(schematics): add test cases for method-calls and import checks #13157

merged 1 commit into from
Sep 18, 2018

Conversation

@devversion
Copy link
Member

@devversion devversion commented Sep 17, 2018

  • With the goal of having test cases for each type of source code transformation, this adds test cases for the method-call checks and import-checks.

@devversion
refactor(schematics): add test cases for method-calls and import checks
51a02f9 
* With the goal of having test cases for each type of source code transformation, this adds test cases for the `method-call checks` and `import-checks`.
@devversion devversion added pr: merge safe target: major This PR is targeted for the next major release labels Sep 17, 2018
@devversion devversion requested a review from amcdnl as a code owner September 17, 2018 09:57
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 17, 2018
jelbourn
jelbourn approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 18, 2018
@mmalerba mmalerba merged commit a98c072 into angular:master Sep 18, 2018
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 9, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@amcdnl amcdnl Awaiting requested review from amcdnl

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@devversion @jelbourn @googlebot @mmalerba