Skip to content

fix(list): action list items clickable area not stretching the full width #13099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2018
Merged

fix(list): action list items clickable area not stretching the full width #13099

merged 1 commit into from
Oct 17, 2018

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 12, 2018

  • Fixes the items inside an action list not stretching the complete width of the element, making them hard to click.
  • Fixes the user agent padding throwing off the alignment for buttons used as items in the action list.

@crisbeto
fix(list): action list items clickable area not stretching the full w…
7bea903 
…idth

* Fixes the items inside an action list not stretching the complete width of the element, making them hard to click.
* Fixes the user agent padding throwing off the alignment for buttons used as items in the action list.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Sep 12, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 12, 2018
jelbourn
jelbourn approved these changes Sep 13, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Sep 13, 2018
@josephperrott josephperrott merged commit f3057fa into angular:master Oct 17, 2018
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 9, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @jelbourn @googlebot @josephperrott