fix(overlay): infinite loop when used together with zone-patch-rxjs #13081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the overlay causing the browser to go into an infinite loop if the consumer is using `zone-patch-rxjs`. Fixes angular#12686.
crisbeto
added
P2
googlebot
added
the
cla: yes
Member
Author
|
Marking as P2, because the overlay touches a lot of components and these changes are fixing a regression. |
jelbourn
added
pr: lgtm
action: merge
| subscription.unsubscribe(); | ||
| } | ||
| }); | ||
| // Keeping the host element in DOM the can cause scroll jank, because it still gets |
There was a problem hiding this comment.
typo: "in DOM the" -> "in the DOM"
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the overlay causing the browser to go into an infinite loop if the consumer is using
zone-patch-rxjs.Fixes #12686.