Adds an abstract date selection model #13033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
reviewed
Sep 7, 2018
| abstract isValid(adapter: DateAdapter<D>): boolean; | ||
| } | ||
|
|
||
| export class MatSingleDateSelection<D> extends MatDateSelection<D> { |
Contributor
There was a problem hiding this comment.
We should add an asDate method to this so we can get a date to pass back to the user
| } | ||
| } | ||
|
|
||
| export class MatRangeDateSelection<D> extends MatDateSelection<D> { |
Contributor
There was a problem hiding this comment.
similarly, this can have an asRange method
mmalerba
approved these changes
Sep 7, 2018
jelbourn
pushed a commit
that referenced
this pull request
Sep 11, 2018
This PR also includes a single date implementation of the selection model and the range implementation.
mmalerba
pushed a commit
that referenced
this pull request
Sep 19, 2018
This PR also includes a single date implementation of the selection model and the range implementation.
roboshoes
added a commit
to roboshoes/material2
that referenced
this pull request
Oct 16, 2018
This PR also includes a single date implementation of the selection model and the range implementation.
mmalerba
pushed a commit
that referenced
this pull request
Oct 16, 2018
This PR also includes a single date implementation of the selection model and the range implementation.
mmalerba
pushed a commit
that referenced
this pull request
Oct 23, 2018
This PR also includes a single date implementation of the selection model and the range implementation.
mmalerba
pushed a commit
that referenced
this pull request
Oct 30, 2018
This PR also includes a single date implementation of the selection model and the range implementation.
mmalerba
pushed a commit
that referenced
this pull request
Oct 31, 2018
This PR also includes a single date implementation of the selection model and the range implementation.
mmalerba
pushed a commit
that referenced
this pull request
Dec 14, 2018
* adds an abstract date selection model and a single date and range implementation * moves adapter to contructor * adds asDate and asRange convertions * adds explicit constructors to concrete implementations * Adds an abstract date selection model (#13033) This PR also includes a single date implementation of the selection model and the range implementation. * WIP uses date selectio in calendar * Observable in MatDateSelection (#13037) This change adds an observable to the date selection. This allows the usage of a single date selection instance instead of creating multiple. * test fixes * small cleanup * cleanup * improves calendar body test spec * fixes tests in month view * fixes matCalendar tests * cleared up calendar body tests with date injection * indent * cleaning up some nits * fixes the final tests * update today programatically * remove unused file * nits
mmalerba
pushed a commit
that referenced
this pull request
Dec 14, 2018
This PR also includes a single date implementation of the selection model and the range implementation.
mmalerba
pushed a commit
that referenced
this pull request
Dec 14, 2018
* adds an abstract date selection model and a single date and range implementation * moves adapter to contructor * adds asDate and asRange convertions * adds explicit constructors to concrete implementations * Adds an abstract date selection model (#13033) This PR also includes a single date implementation of the selection model and the range implementation. * WIP uses date selectio in calendar * Observable in MatDateSelection (#13037) This change adds an observable to the date selection. This allows the usage of a single date selection instance instead of creating multiple. * test fixes * small cleanup * cleanup * improves calendar body test spec * fixes tests in month view * fixes matCalendar tests * cleared up calendar body tests with date injection * indent * cleaning up some nits * fixes the final tests * update today programatically * remove unused file * nits
mmalerba
pushed a commit
that referenced
this pull request
Jan 15, 2019
This PR also includes a single date implementation of the selection model and the range implementation.
mmalerba
pushed a commit
that referenced
this pull request
Jan 15, 2019
* adds an abstract date selection model and a single date and range implementation * moves adapter to contructor * adds asDate and asRange convertions * adds explicit constructors to concrete implementations * Adds an abstract date selection model (#13033) This PR also includes a single date implementation of the selection model and the range implementation. * WIP uses date selectio in calendar * Observable in MatDateSelection (#13037) This change adds an observable to the date selection. This allows the usage of a single date selection instance instead of creating multiple. * test fixes * small cleanup * cleanup * improves calendar body test spec * fixes tests in month view * fixes matCalendar tests * cleared up calendar body tests with date injection * indent * cleaning up some nits * fixes the final tests * update today programatically * remove unused file * nits
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Jan 27, 2019
This PR also includes a single date implementation of the selection model and the range implementation.
mmalerba
pushed a commit
to mmalerba/components
that referenced
this pull request
Jan 27, 2019
* adds an abstract date selection model and a single date and range implementation * moves adapter to contructor * adds asDate and asRange convertions * adds explicit constructors to concrete implementations * Adds an abstract date selection model (angular#13033) This PR also includes a single date implementation of the selection model and the range implementation. * WIP uses date selectio in calendar * Observable in MatDateSelection (angular#13037) This change adds an observable to the date selection. This allows the usage of a single date selection instance instead of creating multiple. * test fixes * small cleanup * cleanup * improves calendar body test spec * fixes tests in month view * fixes matCalendar tests * cleared up calendar body tests with date injection * indent * cleaning up some nits * fixes the final tests * update today programatically * remove unused file * nits
mmalerba
pushed a commit
that referenced
this pull request
Apr 15, 2019
This PR also includes a single date implementation of the selection model and the range implementation.
mmalerba
pushed a commit
that referenced
this pull request
Apr 15, 2019
* adds an abstract date selection model and a single date and range implementation * moves adapter to contructor * adds asDate and asRange convertions * adds explicit constructors to concrete implementations * Adds an abstract date selection model (#13033) This PR also includes a single date implementation of the selection model and the range implementation. * WIP uses date selectio in calendar * Observable in MatDateSelection (#13037) This change adds an observable to the date selection. This allows the usage of a single date selection instance instead of creating multiple. * test fixes * small cleanup * cleanup * improves calendar body test spec * fixes tests in month view * fixes matCalendar tests * cleared up calendar body tests with date injection * indent * cleaning up some nits * fixes the final tests * update today programatically * remove unused file * nits
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also includes a single date implementation of the selection model and the range implementation.