fix(button): hover styles taking precedence over focus styling #13011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the `:hover` styles overriding the focused styling, because they have the same specificity, but are positioned lower in the stylesheet.
googlebot
added
the
cla: yes
jelbourn
approved these changes
Sep 6, 2018
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
Caretaker note: this will affect some screenshot tests, but only ones that happen to capture a button that is both hovered and focused at the same time, so hopefully it will be minimal.
jelbourn
added
pr: lgtm
action: merge
josephperrott
approved these changes
Sep 10, 2018
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 11, 2018
Aligns the button component with the latest Material design spec. This includes the changes from angular#12537 and angular#13011.
Member
Author
|
Closing in favor of #13083. |
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 18, 2018
Aligns the button component with the latest Material design spec. This includes the changes from angular#12537 and angular#13011.
mmalerba
pushed a commit
that referenced
this pull request
Sep 19, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
:hoverstyles overriding the focused styling, because they have the same specificity, but are positioned lower in the stylesheet.Note: the same could be achieved by adding
:not(.cdk-focused)to the hover selector, but I opted into this approach, because it doesn't increase the hover specificity further.