Skip to content

cleanup(stepper): remove unused class #13006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2019
Merged

cleanup(stepper): remove unused class #13006

merged 1 commit into from
Jan 17, 2019

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 6, 2018

Fixes the stepper not setting the proper font size for custom number icons.

Fixes #12999.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Sep 6, 2018
@crisbeto crisbeto requested a review from mmalerba as a code owner September 6, 2018 16:26
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 6, 2018
mmalerba
mmalerba reviewed Oct 18, 2018
View reviewed changes
src/lib/stepper/step-header.scss Outdated
height: $mat-step-header-icon-size;
width: $mat-step-header-icon-size;
.mat-step-icon,
.mat-step-icon-not-touched {
Copy link
Contributor

@mmalerba mmalerba Oct 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this class has since been removed

Copy link
Member Author

@crisbeto crisbeto Oct 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still one selector in master that's referring to it.

Copy link
Contributor

@mmalerba mmalerba Oct 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove it then, because the class is never actually applied to any elements

Copy link
Member Author

@crisbeto crisbeto Oct 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member Author

@crisbeto crisbeto Oct 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this ended up being reduced to just removing that extra selector. I can close it if necessary.

@crisbeto crisbeto force-pushed the 12999/custom-stepper-icon-size branch from 74285bd to f61e9d2 Compare October 18, 2018 21:11
@ngbot
Copy link

ngbot bot commented Oct 23, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto crisbeto force-pushed the 12999/custom-stepper-icon-size branch from f61e9d2 to 726e053 Compare October 24, 2018 19:59
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 16, 2018
@mmalerba mmalerba changed the title fix(stepper): inconsistent icon size for custom icons cleanup(stepper): remove unused class Nov 16, 2018
@mmalerba mmalerba added the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label Nov 16, 2018
@crisbeto crisbeto force-pushed the 12999/custom-stepper-icon-size branch from 726e053 to f5ff7d9 Compare December 13, 2018 17:43
@crisbeto
fix(stepper): inconsistent icon size for custom icons
ddb6b8d 
Fixes the stepper not setting the proper font size for custom number icons.

Fixes angular#12999.
@crisbeto crisbeto force-pushed the 12999/custom-stepper-icon-size branch from f5ff7d9 to ddb6b8d Compare January 2, 2019 11:12
@vivian-hu-zz vivian-hu-zz merged commit e982e36 into angular:master Jan 17, 2019
s2-abdo pushed a commit to s2-abdo/material2 that referenced this pull request Jan 18, 2019
@crisbeto
cleanup(stepper): remove unused class (angular#13006)
299cfc9 
Fixes the stepper not setting the proper font size for custom number icons.

Fixes angular#12999.
vivian-hu-zz pushed a commit that referenced this pull request Jan 18, 2019
@crisbeto
cleanup(stepper): remove unused class (#13006)
c6b96a2 
Fixes the stepper not setting the proper font size for custom number icons.

Fixes #12999.
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmalerba mmalerba mmalerba left review comments

Assignees

@mmalerba mmalerba

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Stepper icon override not same size on not-touched steps

4 participants

@crisbeto @mmalerba @googlebot @vivian-hu-zz