feat(select): align panel appearance and animation with 2018 material design spec #12975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
googlebot
added
the
cla: yes
… design spec Aligns the `mat-select` animation, elevation and border radius with the most-recent Material Design spec. This is the first step towards aligning the component. The next step is to reduce the font size and add some padding to the select panel. The font size and padding changes weren't done in this PR, because they require changes to the positioning logic and reworking the positioning tests.
crisbeto
force-pushed
the
select-new-spec-step-1
branch
from
0cfa422 to
7fc22fd
Compare
josephperrott
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns the
mat-selectanimation, elevation and border radius with the most-recent Material Design spec. This is the first step towards aligning the component. The next step is to reduce the font size and add some padding to the select panel. The font size and padding changes weren't done in this PR, because they require changes to the positioning logic and reworking the positioning tests.