fix(tooltip): not showing up on touch devices #12940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently if someone long presses a tooltip trigger on a touch device, the tooltip will not show up. This is because the `longpress` event does reset immediately and not fire if a `slide` event is being recognized. The `slide` event most likely fires most of the time because of a `threshold = 0` (for smooth sliding) Fixes angular#12917
devversion
added
P2
googlebot
added
the
cla: yes
devversion
added a commit
to devversion/material2
that referenced
this pull request
Sep 1, 2018
* Due to the fact that the sort module uses the `(longpress)` event, the custom HammerJS gesture config needs to be provided. Related to angular#12940
jelbourn
pushed a commit
that referenced
this pull request
Sep 6, 2018
* Due to the fact that the sort module uses the `(longpress)` event, the custom HammerJS gesture config needs to be provided. Related to #12940
jelbourn
pushed a commit
that referenced
this pull request
Sep 11, 2018
* Currently if someone long presses a tooltip trigger on a touch device, the tooltip will not show up. This is because the `longpress` event does reset immediately and not fire if a `slide` event is being recognized. The `slide` event most likely fires most of the time because of a `threshold = 0` (for smooth sliding) Fixes #12917
mmalerba
pushed a commit
that referenced
this pull request
Sep 23, 2018
* Currently if the `MatTooltip` directive is being used without any other modules that set up our "Material" hammer gesture config, the tooltip will use the default `platform-browser` gesture config and **never** fire the `(longpress)` event. This could have been probably added to #12940, but I figured that out later and should be fine that way too. Related to #12917
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
* Currently if the `MatTooltip` directive is being used without any other modules that set up our "Material" hammer gesture config, the tooltip will use the default `platform-browser` gesture config and **never** fire the `(longpress)` event. This could have been probably added to angular#12940, but I figured that out later and should be fine that way too. Related to angular#12917
vivian-hu-zz
pushed a commit
that referenced
this pull request
Nov 6, 2018
* Due to the fact that the sort module uses the `(longpress)` event, the custom HammerJS gesture config needs to be provided. Related to #12940
devversion
added a commit
to devversion/material2
that referenced
this pull request
Nov 8, 2018
* Due to the fact that the sort module uses the `(longpress)` event, the custom HammerJS gesture config needs to be provided. Related to angular#12940
devversion
added a commit
to devversion/material2
that referenced
this pull request
Nov 10, 2018
* Due to the fact that the sort module uses the `(longpress)` event, the custom HammerJS gesture config needs to be provided. Related to angular#12940
devversion
added a commit
to devversion/material2
that referenced
this pull request
Jun 7, 2019
* Due to the fact that the sort module uses the `(longpress)` event, the custom HammerJS gesture config needs to be provided. Related to angular#12940
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
longpressevent does reset immediately and not fire if aslideevent is being recognized. Theslideevent most likely fires most of the time because of athreshold = 0(for smooth sliding)Fixes #12917